Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the user guide for launching instances via the dashboard by removing the 'NeSI' prefix from the dashboard name and the sandbox environment example. Feedback was provided to correct grammatical errors and improve the readability of the network configuration note.
|
|
||
| !!! note | ||
| If you haven't configured a network prior to the creation of a compute instance then the recommend network should be the one that has the same name as the project you are in. Example, I am in the `NeSI-SandBox-Environment` so I will pick the `NeSI-SandBox-Environment` network. | ||
| If you haven't configured a network prior to the creation of a compute instance then the recommend network should be the one that has the same name as the project you are in. Example, I am in the `SandBox-Environment` so I will pick the `SandBox-Environment` network. |
Contributor
There was a problem hiding this comment.
The word 'recommend' should be 'recommended' for correct grammar. Additionally, adding a comma after 'compute instance' and using 'For example' instead of 'Example' improves readability.
Suggested change
| If you haven't configured a network prior to the creation of a compute instance then the recommend network should be the one that has the same name as the project you are in. Example, I am in the `SandBox-Environment` so I will pick the `SandBox-Environment` network. | |
| If you haven't configured a network prior to the creation of a compute instance, then the recommended network should be the one that has the same name as the project you are in. For example, if I am in the SandBox-Environment, I will pick the SandBox-Environment network. |
|
Test deployment available at https://callumwalley.github.io/mkdocs-demo-deploy/nesi/research-developer-cloud/janamakar-patch-3 See all deployed demo sites |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.